Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mirror site lts version error ! #360

Closed
wants to merge 2 commits into from
Closed

Some mirror site lts version error ! #360

wants to merge 2 commits into from

Conversation

lonsenluo
Copy link

Some mirror site stored more then one lts version.So need sort to select max version.

@qw3rtman
Copy link
Collaborator

I think the proper fix would be to line 658.

Additionally, simply calling sort -u -r could create problems (it would say 1.2.15 < 1.2.4, which is not true). Instead sort -u -k 1,1n -k 2,2n -k 3,3n -t should be used as done on line 645 and line 677.

Thanks for pointing this out!

@shadowspawn
Copy link
Collaborator

I think the sort got changed from reverse order to normal in the extra commit, so the head needs to change to tail to match (and the other filters use tail).

However, there is a new PR now, so no need to update this one and could just close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants