Prune using goroutines[capped by CPU] #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaskarsaraogi
commented
Nov 19, 2017
prune.go
Outdated
| // remove and skip dir | ||
| // spawn fo routine to do the removal | ||
| wg.Add(1) | ||
| go p.remove(path, info, &wg, errorChan) |
There was a problem hiding this comment.
could even move this part above and do the stats(atomic inc the stats value then though) counting in goroutine itself ?
but before that trying to see if any of this makes sense/adds value ?
There was a problem hiding this comment.
hmm I think a goroutine per file is a big excessive maybe. I wonder if just launching one per cpu, will maybe improve the performance, as there's maybe contention
There was a problem hiding this comment.
Maybe something like a threadpool?
bhaskarsaraogi
changed the title
|
tweaked a bit! seems to improve the perf almost 50% on my machine |
|
great! thats a lot cleaner too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, was just trying out the idea from #3
Have tried a couple of use cases, works fine. No great perf improvements though.
Looking for your comments, trying to see if it makes any sense ?