-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for functions #13
Conversation
…rk with in streaming contexts
Is this ready for testing/review @phayes ? Got a couple function-y things I'm trying to do haha |
Hi @Kodylow , Yes! Although I snuck a bunch of other changes in here as well. Let me know if you'd like me to split it into a bunch of different PRs. The only thing missing is documentation. |
I've marked this ready for review:
|
My apologies, as I did some final testing I ran into a bunch of small issues that are now fixed. I've also added I don't intend on making any more changes now. Please review! |
🥳 |
This PR implements preliminary support for functions.
Not ready for merge yet, but the skeleton is here and ready for feedback.
Everything is fairy straightforward with the exception of JSONSchema. Instead of adding a dependency on the
schemars
crate and requiring a fully-typed SchemaObject, which is hellish, I simply usedserde_json::Value
and left it up to the user to either useschemars
, or construct something by hand, or deserialize something etc.I'll add some good documentation to this before this PR is ready to merge.