Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed ETDRS/logMAR notation fails #11

Closed
tjebo opened this issue Jun 16, 2020 · 1 comment
Closed

mixed ETDRS/logMAR notation fails #11

tjebo opened this issue Jun 16, 2020 · 1 comment

Comments

@tjebo
Copy link
Owner

tjebo commented Jun 16, 2020 

va(c(25, 23, 0.1), to = "snellen", from = "etdrs")
[1] NA      NA      "20/25"
Warning message:
NA introduced (c(25, 23, 0.1)) - implausible values

Does not recognize mixed ETDRS/logMAR notation. Argument from not recognized.
tjebo added a commit that referenced this issue Jun 18, 2020
@tjebo
Issue #11 added "mixed" argument.
8063f1f 
Fix convertVA.etdrs and fix which_va
@tjebo
Copy link
Owner Author

tjebo commented Jun 18, 2020 

va(c(1,3, 0.4), mixed = TRUE, from_logmar = FALSE)
Mixed object (c(1, 3, 0.4)) - converting one by one
[1] 1.68 1.64 0.40

va(c(25, 23, 0.4), mixed = TRUE)
Mixed object (c(25, 23, 0.4)) - converting one by one
[1] 1.20 1.24 0.40

va(c(25, 23, 0.4))
Notation ambiguous - logMAR picked. Change to etdrs with "from_logmar = FALSE"
[1]  NA  NA 0.4

 va(c(25, 23, 0.4), from_logmar = FALSE)
c(25, 23, 0.4): from etdrs
[1] 1.20 1.24   NA

@tjebo tjebo closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjebo