Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when quality VA with etdrs to logmar, returning 1.7 #24

Closed
tjebo opened this issue Jan 8, 2021 · 3 comments
Closed

when quality VA with etdrs to logmar, returning 1.7 #24

tjebo opened this issue Jan 8, 2021 · 3 comments

Comments

@tjebo
Copy link
Owner

tjebo commented Jan 8, 2021

to_logmar(c("nlp", 34), from = "etdrs")
#[1] 1.70 1.02

to_snellen() works as expected:

to_snellen(c("nlp", 34), from = "etdrs")
#[1] "20/20000" "20/200"  
@tjebo
Copy link
Owner Author

tjebo commented Jan 8, 2021

current suggested workaround: to_logmar(to_snellen(x)).
This is not ideal, I'll fix this ASAP

@tjebo
Copy link
Owner Author

tjebo commented Jan 9, 2021

with current dev version - still need to work on the conversion to logmar, but it's already better.

> to_snellen(c("nlp", "lp", 34), from = "etdrs")
[1] "20/20000" "20/10000" "20/200"  
> to_logmar(c("nlp", "lp", 34), from = "etdrs")
[1] 6.14 3.92 1.02

tjebo added a commit that referenced this issue Jan 9, 2021
@tjebo
Copy link
Owner Author

tjebo commented Jan 9, 2021

fixed with current dev version

> to_snellen(c("nlp", "lp", 34), from = "etdrs")
[1] "20/20000" "20/10000" "20/200"  
> to_logmar(c("nlp", "lp", 34), from = "etdrs")
[1] 3.00 2.70 1.02

@tjebo tjebo closed this as completed Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant