Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird conversion when noplus = TRUE #37

Closed
tjebo opened this issue Aug 24, 2021 · 1 comment
Closed

weird conversion when noplus = TRUE #37

tjebo opened this issue Aug 24, 2021 · 1 comment

Comments

@tjebo
Copy link
Owner

tjebo commented Aug 24, 2021

??

library(eye)
va("6/5", noplus = TRUE, to = "logmar")
#> From snellen
#> [1] -0.07918125

Created on 2021-08-24 by the reprex package (v2.0.0)

tjebo added a commit that referenced this issue Aug 24, 2021
@tjebo
Copy link
Owner Author

tjebo commented Aug 24, 2021

this was in fact a proper conversion to logMAR, but doesn't make sense in a way, because Snellen fractions are just not very precise. LogMAR values are now calculated rounded to the first digit when using noplus = TRUE

@tjebo tjebo closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant