Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion from Snellen decimal fails #9

Closed
tjebo opened this issue Jun 13, 2020 · 2 comments
Closed

Conversion from Snellen decimal fails #9

tjebo opened this issue Jun 13, 2020 · 2 comments

Comments

@tjebo
Copy link
Owner

tjebo commented Jun 13, 2020 •
edited
Loading

va(0.08) or even va(0.08, from = "logmar") results in NA.

0.08 should also be allowed for logmar, because of possible conversion first from ETDRS to logMAR, then back.
@tjebo
Copy link
Owner Author

tjebo commented Jun 13, 2020

A possible solution would be to make which_va output 'logmar' as well and default detected class to logmar, but allow the user to select snellen decimal with "from"

tjebo added a commit that referenced this issue Jun 18, 2020
@tjebo
Issue #9 fix Snellen decimal conversion
ebb9625 
Removed from argument, replaced with from_logmar
@tjebo
Copy link
Owner Author

tjebo commented Jun 18, 2020

Simplified from argument to "from_logmar"

va(0.08, from_logmar = FALSE)
0.08: from snellen
[1] 1.1

va(0.08)
Ambiguous: snellen or logmar - logMAR picked!
              Change to other with "from_logmar = FALSE"
0.08 already in desired notation. Updated to class logmar
[1] 0.08

@tjebo tjebo closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjebo