-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progressive JPEG files by default? #142
Comments
I couldn't replicate this. Are you perhaps using mozjpeg, and not libjpeg? (I was testing with jpegoptim compiled against latest libjpeg). |
Thanks for you reply. I just use the pre-compiled jpegoptim program 1.5.3 x64 for Windows, which I downloaded from this website. Nothing else. So my conclusion is that the pre-compliled version of Jpegoptim converts normal Jpeg files to progressive Jpeg files. |
Looks like it must be mozjpeg library doing this. It seems to default to progressive (presumably because that typically produces slightly smaller files than non-progressive mode), so its not 100% compatible with libjpeg.... Have to see if there is way to make it behave like libjpeg in this regard. |
Thanks. |
I think this should now be fixed. If you want to test the fix, you can find binaries here: https://github.com/tjko/jpegoptim/actions/runs/4559486709 |
Thanks. The behaviour for normal Jpeg files is correct now, So for best optimization of progressive jpeg files the switch --all-progressive is needed according to my tests. |
Maybe better (less intrusive) is to implement new option like --preserve-mode that could be used if someone wants to prevent JPEG changing from normal to progressive during optimization. Since most users likely just want smallest possible file (by default) and progressive vs non-progressive JPEG is not a factor at all... (?) |
Hello. I think that a --preserve-mode switch is a good idea. An other minor thing, maybe the help option of the program should not display unavailable option, Thanks. |
@starleafs, can you provide the actual image file(s)? So I could test, if I can reproduce the issue you're seeing. |
Hello,
sorry Timo. I can’t check that. I don’t own devices from Apple or have Access to them Right now.
Gesendet von Mail<https://go.microsoft.com/fwlink/?LinkId=550986> für Windows
…________________________________
Von: Timo Kokkonen ***@***.***>
Gesendet: Monday, October 30, 2023 5:18:18 AM
An: tjko/jpegoptim ***@***.***>
Cc: wwinniww ***@***.***>; Author ***@***.***>
Betreff: Re: [tjko/jpegoptim] Progressive JPEG files by default? (Issue #142)
I noticed that progressive jpegs not showing correctly on mac/ios jpegoptim version 1.5.3 windows
When I covert images using standard method (jpegoptim.exe --max=90), I received images display wired colour lines opening with mac/ios, but images display correctly on PC. After reading this post, i use non-progressive method (jpegoptim.exe --max=90 --all-normal), I received images display correctly both on PC/Mac
is it a bug? I've attched screenshot and sample images below
@starleafs<https://github.com/starleafs>, can you provide the actual image file(s)? So I could test, if I can reproduce the issue you're seeing.
―
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6Z4OIT7HNGZRS6WMA5WXQ3YB4TAVAVCNFSM6AAAAAAWLAXU32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGQ2TGMZSGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hello, I tested again with jpegoptim version 1.5.5 and I think this bug was fixed on version v1.5.4 (Fix mozjpeg not preserving JPEG mode (progressive vs normal) by @tjko in #143 thanks. |
I use the windows 64 bit compile of jpegoptim 1.5.3
I noticed that every optimized jpeg file is progressive, but I don't specify --all-progressive as command line parameter.
Shouldn't be the default operation unless specified otherwise to keep sequential JPEG instead of converting every JPEG file into progressive JPEG?
The text was updated successfully, but these errors were encountered: