Add implementation of includes and unit tests #111
Conversation
|
One note: my unit tests wont hit https://github.com/cflynn07/101/blob/109-add-includes/includes.js#L28 Want to monkey patch |
Array.prototype.includes = sinon.stub().returns(42);
// create a new array
// search said array
// assert 42 was returned (whatever .includes returns this should return)
// delete (.restore() may not do it) the stubbed includes methodTyping that on an iPad is tough. But, that's what I would do in a test. Doesn't need to actually search it, just return whatever includes would procide. It's weird adding functions to global namespace, but you can give it a try! |
| while (k < len) { | ||
| currentElement = O[k]; | ||
| if (searchElement === currentElement || | ||
| (searchElement !== searchElement && currentElement !== currentElement)) { |
There was a problem hiding this comment.
My brain is struggling with this second half of the if statement (it is also before 6am...) why would you check that both aren't equal to themselves? Feels like a very JavaScript thing to do though...
There was a problem hiding this comment.
That's a great question. This code is copy/pasted from MDN documentation. I'm not sure what the purpose of that is. I asked a question here:
http://stackoverflow.com/questions/33068441/es7-array-prototype-includes-polyfill-double-equality-comparison
There was a problem hiding this comment.
Some more information here: https://tc39.github.io/Array.prototype.includes/
If SameValueZero(searchElement, elementK) is true, return true.
http://www.ecma-international.org/ecma-262/6.0/index.html#sec-samevaluezero
There was a problem hiding this comment.
Correct identification of values such as NaN and -0 && 0 as equal
There was a problem hiding this comment.
Will add a test for those conditions
|
LGTM, just missing 100% test-coverage |
|
Will add documentation tomorrow |
|
How about some partial functionality goodness so we can support the example in #109? |
|
That's present in this PR. I'll add a doc example of it Sent from my iPhone
|
|
👍 |
Add implementation of includes and unit tests
|
101@v1.2.0 |
Implementation for #109
Went a little further than the functionality in the proposed example of 109 and added an optional "fromIndex" argument to limit search space of array (functionality as defined in ES7 proposal).