Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep metadata signal #58

Merged
merged 5 commits into from
Sep 27, 2020
Merged

Keep metadata signal #58

merged 5 commits into from
Sep 27, 2020

Conversation

ericpre
Copy link
Collaborator

@ericpre ericpre commented Sep 24, 2020

  • Keep metadata from the original signal
  • Add denoised suffix to signal title
  • fix example notebook (negative value error).
  • Remove optional openblas dependency.

For the last item, I don't know if this is the better approach to deal with this optional dependency of the C extensions.

@tjof2
Copy link
Owner

tjof2 commented Sep 27, 2020

LGTM, thanks!

@tjof2 tjof2 merged commit 53f684e into tjof2:master Sep 27, 2020
@ericpre ericpre mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjof2 tjof2 tjof2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpre @tjof2