Fix circular references issue #1
Conversation
Sources/Yams/Constructor.swift
Outdated
| case .unresolved: | ||
| fatalError("Unable to get Swift value from unresolved node type.") |
There was a problem hiding this comment.
This is what I'm troubleshooting now. Once this is fixed, I should be able to make a PR against YAMS.
| /// The plain scalar style. | ||
| case plain | ||
|
|
||
| /// The single-quoted scalar style. | ||
| case singleQuoted | ||
| /// The double-quoted scalar style. | ||
| case doubleQuoted | ||
|
|
||
| /// The literal scalar style. | ||
| case literal | ||
| /// The folded scalar style. | ||
| case folded | ||
| } |
There was a problem hiding this comment.
This is literally copy-paste from Node.Scalar so it may not be necessary.
| } | ||
|
|
||
| func loadNode(from event: Event) throws -> Node { | ||
| switch event.type { | ||
| case YAML_ALIAS_EVENT: | ||
| return try loadAlias(from: event) | ||
| do { | ||
| return try loadAlias(from: event) |
There was a problem hiding this comment.
can we change the loadAlias to do return Node(unresolved: alias, error: yamlError) when an alias is not found in anchor array? instead of throw an exception in loadAlias and then catch it in loadNode and return Node(unresolved: alias, error: yamlError)
| /// This node's tag (its type). | ||
| public var tag: Tag | ||
| /// The style to be used when emitting this node. | ||
| public var style: Style |
There was a problem hiding this comment.
Do we need 'style' for Node.Unresolved'? I think we can try removing 'style' and also the Style enum.
| /// Create a `Node.scalar` with a string, tag & scalar style. | ||
| /// | ||
| /// - parameter alias: Alias value for this node. | ||
| /// - parameter tag: Tag for this node. |
| @@ -45,6 +47,49 @@ extension Node { | |||
| public init(_ nodes: [Node], _ tag: Tag = .implicit, _ style: Sequence.Style = .any) { | |||
| self = .sequence(.init(nodes, tag, style)) | |||
| } | |||
|
|
|||
| /// Create a `Node.scalar` with a string, tag & scalar style. | |||
| } | ||
| } | ||
|
|
||
| /// Get or set the `Node.Unresolved` value if this node is a `Node.undefined`. |
There was a problem hiding this comment.
what is 'Node.undefined' in this context?
| case let .mapping(mapping): | ||
| var map = [(Node, Node)]() | ||
| var iterator = mapping.makeIterator() | ||
| while true { |
There was a problem hiding this comment.
i suggest to remove the while true loop
No description provided.