-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only import propBoolean from Prop #133
Only import propBoolean from Prop #133
Conversation
I pushed a commit changing the JDK for Travis CI to avoid Oracle's (which hasn't been available on Travis CI for a while). |
I agree that only importing definitions that are needed is generally better.
instead of:
Maybe |
@fthomas The problem is that if we don't use the wildcard import then we'll get an unused import warning / failure for |
|
@fthomas Sounds good, done! |
@travisbrown Thank you for the PR. Please try 0.9.6 which I just published. |
@tkawachi I just tried it out in a project where I was seeing warnings, and they're gone. Thanks much! |
I noticed this because of a change in Dotty that I think is a bug, but I think it's the right thing to do anyway, since importing
Prop._
brings in a lot of other definitions that aren't needed.