Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bug fix and a new feat #9

Merged
merged 5 commits into from
Dec 18, 2020
Merged

some bug fix and a new feat #9

merged 5 commits into from
Dec 18, 2020

Conversation

RayHuangCN
Copy link
Member

fix: coordinator: remove all auth in injected config file
fix: coordinator: remove deleted job targets in "discovery" module when config file changed
fix: sidecar: statistic sample before copy data to prometheus
fix: coordinator: wait first service discovery done before coordinator loop
feat: all: support redirect path of serviceaccount token and ca

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #9 (b49b933) into master (a3f507f) will decrease coverage by 1.70%.
The diff coverage is 58.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   78.14%   76.44%   -1.71%     
==========================================
  Files          25       25              
  Lines         929      989      +60     
==========================================
+ Hits          726      756      +30     
- Misses        122      139      +17     
- Partials       81       94      +13     
Impacted Files Coverage Δ
pkg/shard/replicas.go 72.97% <0.00%> (+3.74%) ⬆️
pkg/sidecar/proxy.go 86.66% <0.00%> (ø)
pkg/target/status.go 100.00% <ø> (ø)
pkg/shard/group.go 70.31% <33.33%> (-2.27%) ⬇️
pkg/coordinator/coordinator.go 70.83% <43.75%> (-5.00%) ⬇️
pkg/prom/commonapi.go 53.84% <50.00%> (-12.83%) ⬇️
pkg/coordinator/service.go 75.71% <58.33%> (ø)
pkg/sidecar/service.go 59.25% <59.25%> (ø)
pkg/discovery/discovery.go 82.25% <78.94%> (+0.43%) ⬆️
pkg/sidecar/injector.go 80.51% <100.00%> (+2.59%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f507f...b0f725a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant