fix(platform): fix selinux validation #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxiaoliang
reviewed
Jan 4, 2023
pkg/util/ssh/os.go
Outdated
| stdout, _, exit, err := s.Exec("selinuxenabled") | ||
| if err != nil || exit != 0 { | ||
| // https://www.thegeekdiary.com/how-to-check-whether-selinux-is-enabled-or-disabled/ | ||
| stdout, _, _, err := s.Exec("selinuxenabled; echo $?;") |
There was a problem hiding this comment.
I think you can use the the third return value for Exec function rather than run "echo $?" manually
leoryu
force-pushed
the
fix-selinux-validation
branch
from
e5ae35b
to
0dcbca8
Compare
huxiaoliang
approved these changes
Jan 4, 2023
huxiaoliang
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: