Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training set and accuracy calculation #26

Closed
cshjin opened this issue Mar 13, 2019 · 6 comments
Closed

Training set and accuracy calculation #26

cshjin opened this issue Mar 13, 2019 · 6 comments

Comments

@cshjin
Copy link

cshjin commented Mar 13, 2019

Hi @tkipf
When I review the code, the training set you generated is a subgraph of the original graph, while in model when calculating the loss, the function weighted_cross_entropy_with_logits compares the pred_scores and the subgraph adjacency matrix.

The ones in the subgraph adjacency matrix represent the train_edge, while the zeros have both val_edges_false and test_edge_false as the trainings. Is that true?

If yes, what I think the loss should be calculated by sampling the adj_matrix with train_edges and train_edges_false, which represent both 1s and 0s.

Thus, what I think is to split the edges into
E_G = E_train + E_val + E_test
and split the non-existed edges into
\bar{E}_G = \bar{E}_train + \bar{E}_val + \bar{E}_test

Also, since the reconstructed matrix is not a matrix with values from [0, 1].
I think there is a problem when applying the sigmoid function to calculate the accuracy. Most of entries in the reconstruct matrix are positive, and it could leads to a bias calculation. Is that correct?

@tkipf
Copy link
Owner

tkipf commented Mar 15, 2019 via email

@tkipf
Copy link
Owner

tkipf commented Mar 15, 2019 via email

@cshjin
Copy link
Author

cshjin commented Mar 15, 2019

Will it be possible to predict the link based on the node embedding Z_i, Z_j using the metric learning?
Where in the case that we have learned the node embedding from the subgraph, and learn a metric to predict the existence of a link, say f(Z_i, Z_j) = Z_i' W Z_j

@tkipf
Copy link
Owner

tkipf commented Mar 15, 2019 via email

@cshjin
Copy link
Author

cshjin commented Mar 15, 2019

Got it, thanks for your information.

@cshjin cshjin closed this as completed Mar 15, 2019
@jlevy44
Copy link

jlevy44 commented Apr 1, 2019

Why can't we just try to generate the graph from scratch via simulation.

I would like to use these methods to create an ensemble of different graphs that are close to the original graph rather than complete missing edges.

Mainly to compare the statistical properties and solve degeneracy problems with ERGMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants