Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default pair_selector #225

Merged
merged 16 commits into from
Jan 21, 2023
Merged

Move default pair_selector #225

merged 16 commits into from
Jan 21, 2023

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Jan 21, 2023

Summary

Move ssspy._bss._select_pair to ssspy.utils.pair_selector.
In addition, sequential_pair_selector is used in IP2 and ISS2.

close #148

@tky823 tky823 added the bss Blind source separation method label Jan 21, 2023
@tky823 tky823 added this to the v0.2.0 milestone Jan 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 94.66% // Head: 94.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ba61546) compared to base (46061fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          38       39    +1     
  Lines        4573     4575    +2     
=======================================
+ Hits         4329     4331    +2     
  Misses        244      244           
Impacted Files Coverage Δ
ssspy/bss/_select_pair.py 100.00% <100.00%> (ø)
ssspy/bss/_update_spatial_model.py 99.00% <100.00%> (ø)
ssspy/bss/fdica.py 92.50% <100.00%> (ø)
ssspy/bss/ilrma.py 96.90% <100.00%> (-0.02%) ⬇️
ssspy/bss/iva.py 96.19% <100.00%> (-0.02%) ⬇️
ssspy/utils/select_pair.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tky823 tky823 force-pushed the feature/default-pairwise-selector branch from f24f696 to 7d962ea Compare January 21, 2023 12:44
@tky823 tky823 merged commit 5d27992 into main Jan 21, 2023
@tky823 tky823 deleted the feature/default-pairwise-selector branch January 21, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bss Blind source separation method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pair_selectors to utils
2 participants