Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver for cubic equations. #230

Merged
merged 8 commits into from
Feb 10, 2023
Merged

Solver for cubic equations. #230

merged 8 commits into from
Feb 10, 2023

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Feb 10, 2023

Summary

Implement a solver for cubic equations, which will be used in IVA-IPA.

ref: #156

@tky823 tky823 added math Math related issue test Test related issue labels Feb 10, 2023
@tky823 tky823 added this to the v0.3.0 milestone Feb 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 94.39% // Head: 94.41% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c2d237a) compared to base (10d3c9a).
Patch coverage: 97.29% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   94.39%   94.41%   +0.01%     
==========================================
  Files          41       43       +2     
  Lines        5122     5158      +36     
==========================================
+ Hits         4835     4870      +35     
- Misses        287      288       +1     
Impacted Files Coverage Δ
ssspy/linalg/polynomial.py 96.15% <96.15%> (ø)
ssspy/linalg/__init__.py 100.00% <100.00%> (ø)
ssspy/linalg/cubic.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tky823 tky823 merged commit ec946a5 into main Feb 10, 2023
@tky823 tky823 deleted the feature/cubic branch February 10, 2023 16:18
@tky823 tky823 mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
math Math related issue test Test related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants