Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IVA-IPA #234

Merged
merged 64 commits into from
Jun 10, 2023
Merged

Implement IVA-IPA #234

merged 64 commits into from
Jun 10, 2023

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Mar 1, 2023

Summary

This PR implements IVA-IPA proposed in "Independent vector analysis via log-quadratically penalized quadratic minimization".

close #231
close #156

@tky823 tky823 added new feature New feature or request bss Blind source separation method math Math related issue labels Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage: 95.07% and project coverage change: +0.03 🎉

Comparison is base (643000b) 93.99% compared to head (4cab21f) 94.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   93.99%   94.03%   +0.03%     
==========================================
  Files          43       44       +1     
  Lines        5163     5363     +200     
==========================================
+ Hits         4853     5043     +190     
- Misses        310      320      +10     
Impacted Files Coverage Δ
ssspy/linalg/lqpqm.py 92.79% <92.79%> (ø)
ssspy/bss/iva.py 96.23% <96.55%> (-0.01%) ⬇️
ssspy/bss/_update_spatial_model.py 98.85% <98.38%> (-0.15%) ⬇️
ssspy/linalg/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tky823 tky823 added this to the v0.3.0 milestone Mar 13, 2023
@tky823 tky823 added the documentation Improvements or additions to documentation label Mar 14, 2023
@tky823 tky823 marked this pull request as ready for review June 10, 2023 02:25
@tky823 tky823 mentioned this pull request Jun 10, 2023
@tky823 tky823 added the notebooks Related to jupyter notebooks label Jun 10, 2023
@tky823 tky823 merged commit 9428694 into main Jun 10, 2023
17 checks passed
@tky823 tky823 deleted the feature/iva-ipa branch June 10, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bss Blind source separation method documentation Improvements or additions to documentation math Math related issue new feature New feature or request notebooks Related to jupyter notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find largest real root of cubic polynomial Implementation of IVA-IPA
2 participants