D3bootstrap fix147 #154
Merged
D3bootstrap fix147 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Péter Gyarmati <40776291+peter-gy@users.noreply.github.com>
…iew.js Co-authored-by: Péter Gyarmati <40776291+peter-gy@users.noreply.github.com>
…nMetadata` @jorisvanzundert The issue was caused by the fact that plain `fetch` was used instead of `this.fetch`. The former refers to the JS builtin, the latter is the custom function I created for services in which `baseFetch` is called with automatic endpoint transformation. Using the plain `fetch` call, the endpoint was not transformed properly, hence it was forwarded to the middleware in an unexpected format, therefore the route pattern-matching logic got tricked and the route with the `stemmata`suffix got invoked. TLDR: please use `this.fetch` instead of `fetch` inside service classes.
Fixes to Tradition metadata editing.
…3bootstrap_jzlocal
Moved several turning cogs out of stemmaweb.js to move from d3 to custom HTML elements where d3 was not very convenient. Tweaks to layout. Began work on editing section metadata (in progress).
Merge branch 'd3bootstrap' into d3bootstrap_jzlocal
Merge branch 'd3bootstrap' into d3bootstrap_jzlocal
…sults should be more harmonized at some point.
Merge branch 'd3bootstrap' into d3bootstrap_jzlocal
Also fixes an issue where setTimeout would cause an error if an alert already has been closed by a user.
Merge branch 'd3bootstrap' into d3bootstrap_jzlocal
This commit abstracts also form controls to a separate class. Substitutes complicated placing (styling) of dialog by `getComputedStyle()` with a `boundingClientRect()` solution.
Add requested test user/tradition data
fix: no joining of witnesses into string in PropertiesTableView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #147 and #148. Editing of Tradition and Section metadata, as well as reordering of sections (just click and drag) should be operational.