Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Fix POM and remove test from old API #99

Closed
wants to merge 1 commit into from

Conversation

cdjackson
Copy link
Collaborator

I just grabbed a clean fork of the repo to tidy things up a bit, and it looks like the pom is broken and some tests refer to the old API. This just tidies this up - maybe it was like that for a reason, but when starting from a fresh fork, it doesn't work currently.
Signed-off-by: Chris Jackson chris@cd-jackson.com

Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@tlaukkan
Copy link
Owner

Hi

The old API should remain functional for backwards compatibility over one
major release at least. Is the build broken. I think master has been
passing ok with CI build.

Br,
tommi

On Mon, Aug 29, 2016 at 8:05 PM, Chris Jackson notifications@github.com
wrote:

I just grabbed a clean fork of the repo to tidy things up a bit, and it
looks like the pom is broken and some tests refer to the old API. This just
tidies this up - maybe it was like that for a reason, but when starting
from a fresh fork, it doesn't work currently.

Signed-off-by: Chris Jackson chris@cd-jackson.com

You can view, comment on, or merge this pull request online at:

#99
Commit Summary

  • Fix POM and remove test from old API

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#99, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAONRinGQy0vVhvtB4ibS4GsqYPpiIQ8ks5qkxFLgaJpZM4Jvrjw
.

Best regards,
Tommi Laukkanen

@cdjackson
Copy link
Collaborator Author

The pom doesn’t seem to depend on the serial library which stops it working here. That was the main problem I had to get it running from scratch.

@tlaukkan
Copy link
Owner

tlaukkan commented Aug 29, 2016 via email

@cdjackson
Copy link
Collaborator Author

I’m not sure what you’re referring to - if you mean the other discussion on the location of the SerialPort interface, then that shouldn’t be relevant as that’s in another branch. This was an issue in master. Maybe it’s just an eclipse issue if you actually want to run the software.

@tlaukkan
Copy link
Owner

Ok, just made the connection because when I was looking into pull request and was wondering if it will compile due to dependecy problems.

@tlaukkan tlaukkan closed this Dec 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants