Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Node 12 as minimum supported version #109

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

MasterOdin
Copy link
Contributor

Per discussion in #106, this sets the minimum supported version of tldr-lint to Node 12.

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
branches: [ '*' ]
pull_request:
branches: [ '*' ]
on: [push, pull_request]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning this up, the latter covers all the same cases as the former.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MasterOdin MasterOdin merged commit 5303e82 into main Oct 12, 2021
@MasterOdin MasterOdin deleted the mpeveler/chore-node-10 branch October 12, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants