-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curly braces not properly escaped on pages (e.g. docker, playerctl, fakedata) #10125
Comments
Wait, I actually forgot I already opened an issue for this : #10040 |
I think backslash for escaping would be easy to implement in clients. |
@kbdharun Does that mean that the cases mentioned here were fixed in the process ? |
Yes, Once a new client specification release is made. Clients will be able to update their code and fix escaping (by referring to the examples, in client spec). |
Yeah, I know, but does the docker tldr page has been fixed ? |
The docker tldr page indeed hasn't been fixed yet (I will open a PR to update it now), I believe the other case would be An escaped page now will look something like this: |
Great news! Thanks I didn't encounter any other glitched page during my investigation. |
👋🏻 Hi
Problem
On some pages, we actually need to show parenthesis
{{ ... }}
like the ones ofdocker inspect
andplayerctl
for templating.Docker example
where it should be in fact
tldr/pages/common/docker-inspect.md
Line 16 in e9995a8
Research
I tried to find a way to escape these, but after some research, I only found someone that tried to escape for
fakedata
tldr/pages/common/fakedata.md
Line 24 in e9995a8
but it does not actually work
I asked on the Matrix chat, but one told me to open an issue here...
Solution
I'll create a PR as soon as I know how to escape the parentheses to fix most of the pages. I think I can find more example of this issue.
PS: I use
tldr
every day, and it is a great piece of information. ThanksThe text was updated successfully, but these errors were encountered: