-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @pxgamer as an organisation owner #2989
Comments
Hi @sbrl, thanks for the offer! I'm really enjoying being a part of the tldr pages community. 🎉 It would be great to continue participating as an owner. 👍 |
Whoops. 🤔 Opened #2997. @waldyrious, just a quick question. Is the |
I've been thinking about that recently. Ideally we could have the dates for each transition displayed for historical record (and to avoid ambiguity), but I haven't thought of a format that wouldn't be too verbose. Any ideas welcome :) |
Maybe, since we have a |
Hmm. I'm not really that sure 🤔 |
Oops! I totally forgot about that. I really should double-check the instructions :P And yeah, that sounds like a good idea. I like that! |
Are you meaning something like this, or am I just confused? |
Yes, although looking at it, I'm not sure using strikethrough formatting makes it clear that the end of the period meant a progression to another role. It looks like a termination instead :S Maybe let's just mark the current ones as bold, like this. WDYT? |
I think that makes more sense. 👍 So, bold for everyone except old entries. I might just make my name bold in #2997. And then we can have a follow up PR that updates the rest (or decides on a different way of doing it). Does that sound ok? (See MAINTAINERS.md@650618e) In a way, as the headings are |
You're right that the headings and the content are inconsistent. I'd say we remove the "Current" and have the date ranges correspond to the periods when each person was in that role. I'm not sure it makes sense to do the changes in two steps, because the file will be inconsistent — e.g. with a section heading saying "current" including an entry (yours) which isn't current. I could submit a PR updating the formatting and section titles, and your PR would be merged after it, already incorporating the formatting changes. How does that sound? |
That sounds great @waldyrious. 👍 |
@pxgamer thanks for prompting the much-needed update of the format of MAINTAINERS.md :) |
Hi, @pxgamer! You've been an active tldr-pages org member for over 6 months.
Thanks for sticking around this far and helping out!
According to COMMUNITY-ROLES.md, you're now eligible for becoming an owner in the organization.
That means you will, from now on, be part of the team responsible for performing role changes (like this one!) in the community.
Before performing such role transitions, make sure to review the COMMUNITY-ROLES.md document.
Is that OK with you? Let us know!
Either way, thanks so much for all the work you've done so far. You rock!
The text was updated successfully, but these errors were encountered: