Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vf: add page #11219

Merged
merged 3 commits into from
Oct 24, 2023
Merged

vf: add page #11219

merged 3 commits into from
Oct 24, 2023

Conversation

abhishekmj303
Copy link
Contributor

@abhishekmj303 abhishekmj303 commented Oct 24, 2023 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented: 2.5.5

This tool actually has a different command name to use in the terminal, i.e. vf not virtualfish. Should I need to create vf.md also? What is guidelines for this?

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 24, 2023
Magrid0
Magrid0 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

acuteenvy
acuteenvy requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool actually has a different command name to use in the terminal, i.e. vf not virtualfish. Should I need to create vf.md also? What is guidelines for this?

The filename should always be command-name.md.

pages/common/virtualfish.md Outdated Show resolved Hide resolved
@abhishekmj303
Copy link
Contributor Author

@acuteenvy Renamed virtualfish to vf.

acuteenvy
acuteenvy reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed virtualfish to vf.

Thank you. I have some suggestions.

pages/common/vf.md Outdated Show resolved Hide resolved
pages/common/vf.md Outdated Show resolved Hide resolved
@abhishekmj303 @acuteenvy
vf: apply suggestions from code review
2cb69b5 
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@acuteenvy acuteenvy changed the title virtualfish: add page vf: add page Oct 24, 2023
@acuteenvy acuteenvy merged commit 3463e10 into tldr-pages:main Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magrid0 Magrid0 Magrid0 approved these changes

@acuteenvy acuteenvy acuteenvy approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishekmj303 @CLAassistant @Magrid0 @acuteenvy