swapoff: add page #2003
Merged
swapoff: add page #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
requested changes
Feb 17, 2018
There was a problem hiding this comment.
Hi @shashank2806, thanks for the new page!
Just one minor change noted below. 😄
|
|
||
| - Disable a given swap partition: | ||
|
|
||
| `swapoff {{/dev/sdb7}}` |
There was a problem hiding this comment.
Could you change this to path/to/partition?
There was a problem hiding this comment.
Thanks for suggesting edit, but {{/dev/sdb7}} is more consistent with other pages such as mkswap and swapon.
There was a problem hiding this comment.
This should be clarified in the style guide. I've started a discussion on gitter about that, hopefully soon we'll eliminate the ambiguity :)
sbrl
approved these changes
Feb 17, 2018
owenvoke
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.