-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: add page and Italian translation #2764
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page, @grastello! I've left some comments below for you to review.
Suggestions seems good to me, applied to both English and Italian pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @grastello :smiley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello again, @grastello and thank you.
I see you are making a PR from a branch which has 16 commits, some of which were already incorporated in a previous PR and have nothing to do with the requested page addition. This makes it hard to understand which changes are going to be applied. Could you please rebase your branch on upstream/master
to only keep the relevant commits?
I do agree on using "paragraph" instead of "sentence" since it makes more intuitive sense. However the official documentation as well as the man page do use the word "sentence" defining a sentence break as the end of a paragraph. Pretty confusing to be fair. Also sorry for the mess I made with the branch but it should be fixed now. |
@grastello the documentation talks about sentences because it says that breaking lines is done preferring the end of sentences by default. That specific command I was commenting on adds two spaces between paragraphs though. For example:
You can see that two spaces are only used between paragraphs, not sentences (paragraph = group of sentences followed by a newline character). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, looks good to me 👍 thanks @grastello 😄
fmt
pages in English and Italian for #2213.common/
,linux/
, etc.)