Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: playing video from the web #4136

Merged
merged 3 commits into from
Jul 1, 2020
Merged

vlc: playing video from the web #4136

merged 3 commits into from
Jul 1, 2020

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jun 29, 2020

  • The page (if new), does not already exist in the repo.
    • Exists
  • The page is in the correct platform directory (common/, linux/, etc.)
    • Updating already existing page
  • The page has 8 or fewer examples.
    • As of 29.06.2020 page has 4 examples, 5 with mine
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
    • Concluded that it does follow these guidelines
  • The page description includes a link to documentation or a homepage (if applicable).
    • Already present

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/vlc.md:22: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

CLA ain't working on my end

image

and i am not really interested in signing one~

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

The TLDR005 seems irelevant to this issue assuming that i wasn't touching description

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020 •
edited
Loading

GitHub CI: We are currently unable to download the log. Please try again later.

EDIT: Works now, already addressed in #4136 (comment)

@Kreyren Kreyren mentioned this pull request Jun 29, 2020
Open
vlc: Add playing videos from the web
bfbe570 
Submitted under the terms of project license publicly available on
hyperlink https://github.com/tldr-pages/tldr/blob/master/LICENSE.md
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/vlc.md:22: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

Due to the #4136 (comment) addressed CLA in https://github.com/tldr-pages/tldr/pull/4136/commits/bfbe5703ba439fe52cd1c9753bc2cd56cef780e7 see valid signature and commit message

Kreyren pushed a commit to Kreyren/tldr-pages that referenced this pull request Jun 29, 2020
vlc: Addressed TLDR005
27e8f14 
As mensioned in tldr-pages#4136 (comment)

This resolves this issue in separate merge request

Submitted under the terms of project license publicly available on
hyperlink https://github.com/tldr-pages/tldr/blob/master/LICENSE.md
@Kreyren Kreyren mentioned this pull request Jun 29, 2020
Closed
6 tasks
zlatanvasovic
zlatanvasovic suggested changes Jun 29, 2020
View reviewed changes
pages/common/vlc.md Outdated Show resolved Hide resolved
@zlatanvasovic
Update pages/common/vlc.md
916e44d 
Co-authored-by: Zlatan Vasović <zlatanvasovic@gmail.com>
@zlatanvasovic
Copy link
Contributor

@Kreyren Very weird about CLA. Can you try again?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

@Kreyren Very weird about CLA. Can you try again?

Same issue, tried to unblock script and fetch for
cloudflare.com and cla-assistant.io nothing else seems to be requested for noscript.

image

Maybe blocking tor users? The commit should be enough for a CLA though

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

Or like i can make custom CLA and sign it using gpg if you want

@zlatanvasovic
Copy link
Contributor

It must be an issue with your browser (settings). Do you have JavaScript or images blocked?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

Do you have JavaScript or images blocked? @zdroid

I had, allowed them for the mensioned domains which didn't affect the issue too much (just the Hey! dissapeared)

@zlatanvasovic
Copy link
Contributor

@Kreyren I think you need to allow it for github.com too (it uses GitHub API), and maybe for some other. So you know, it's problematic if JS is blocked in your browser.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 29, 2020

Made it to work

image

it needed fetch()

einverne
einverne approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@einverne einverne added the page edit Changes to an existing page(s). label Jul 1, 2020
@zlatanvasovic zlatanvasovic merged commit 3280802 into tldr-pages:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einverne einverne einverne approved these changes

@zlatanvasovic zlatanvasovic Awaiting requested review from zlatanvasovic

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kreyren @CLAassistant @tldr-bot @zlatanvasovic @einverne