Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indent: add page #4443

Merged
merged 3 commits into from
Oct 5, 2020
Merged

indent: add page #4443

merged 3 commits into from
Oct 5, 2020

Conversation

staceybellerose
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Relates to #3689

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2020

CLA assistant check
All committers have signed the CLA.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 3, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @staceybellerose Thanks for your submission, I left some comments.

Also, the docs say:

In the first form, one or more input files are specified. indent makes a backup copy of each file, and the original file is replaced with its indented version.

Could you please add an example with more than 1 file or the file of a specific directory? Is a space-separated list ?

pages/common/indent.md Outdated Show resolved Hide resolved
pages/common/indent.md Outdated Show resolved Hide resolved
@staceybellerose
Copy link
Contributor Author

Hey @staceybellerose Thanks for your submission, I left some comments.

Also, the docs say:

In the first form, one or more input files are specified. indent makes a backup copy of each file, and the original file is replaced with its indented version.

Could you please add an example with more than 1 file or the file of a specific directory? Is a space-separated list ?

I've updated the first example to use the first form, with multiple files specified on the command line.

@staceybellerose
Copy link
Contributor Author

When testing on my Mac, I noticed that it doesn't use the GNU version of indent, but the FreeBSD version, so that has been included as well.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, those are some pretty long lines, but in some cases it can't be helped.

Thanks, @staceybellerose!

@sbrl sbrl merged commit e50c770 into tldr-pages:master Oct 5, 2020
@staceybellerose staceybellerose deleted the indent branch October 8, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants