Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sstat, scontrol: add page #4689

Merged
merged 5 commits into from
Oct 14, 2020
Merged

sstat, scontrol: add page #4689

merged 5 commits into from
Oct 14, 2020

Conversation

npalladium
Copy link
Contributor

@npalladium npalladium commented Oct 14, 2020 •
edited by navarroaxel

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Ref: #2068

@npalladium npalladium changed the title sstat: add page sstat, scontrol: add page Oct 14, 2020
This was referenced Oct 14, 2020
Open
Closed
navarroaxel
navarroaxel requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @npalladium, I left some comments.

pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/sstat.md Outdated Show resolved Hide resolved
pages/linux/sstat.md Outdated Show resolved Hide resolved
pages/linux/sstat.md Outdated Show resolved Hide resolved
npalladium and others added 2 commits October 14, 2020 16:48
@npalladium @navarroaxel
Apply suggestions from code review
fa38238 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@npalladium
Update scontrol.md
7247c45
@npalladium
Copy link
Contributor Author

@navarroaxel, made the requested changes. Also fixed an error on my part. Extremely sorry about that.

navarroaxel
navarroaxel requested changes Oct 14, 2020
View reviewed changes
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/scontrol.md Outdated Show resolved Hide resolved
pages/linux/sstat.md Show resolved Hide resolved
pages/linux/sstat.md Outdated Show resolved Hide resolved
@npalladium @navarroaxel
Apply suggestions from code review
8e33d64 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
navarroaxel
navarroaxel reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conversation leave unresolved #4689 (comment)

navarroaxel
navarroaxel approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @npalladium

sbrl
sbrl approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @npalladium ❤️

@sbrl sbrl merged commit fbfe2c2 into tldr-pages:master Oct 14, 2020
@yutyo yutyo added the new command Issues requesting creation of a new page. label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@npalladium @navarroaxel @sbrl @yutyo