Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw: add page #6557

Merged
merged 7 commits into from
Oct 4, 2021
Merged

raw: add page #6557

merged 7 commits into from
Oct 4, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Sep 18, 2021
@tldr-bot

This comment has been minimized.

Sign in to view
@tldr-bot

This comment has been minimized.

Sign in to view
navarroaxel
navarroaxel reviewed Sep 18, 2021
View reviewed changes
pages/linux/raw.md Outdated Show resolved Hide resolved
marchersimon
marchersimon reviewed Sep 19, 2021
View reviewed changes
pages/linux/raw.md Outdated Show resolved Hide resolved
@marchersimon marchersimon mentioned this pull request Sep 22, 2021
Closed
70 tasks
CleanMachine1 and others added 2 commits September 23, 2021 23:23
@CleanMachine1 @navarroaxel
Change placement of {{
6ecf338 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@CleanMachine1 @marchersimon
Clarify that its a Unix raw device
4f1ba74 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
pixelcmtd
pixelcmtd requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@pixelcmtd pixelcmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you not include -q and -a? (that also requires a description change obviously)

einverne
einverne approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page looks good to me. But I am curious where is this command used?

@pixelcmtd
Copy link
Member

I still think that -q and -a should have examples.

@CleanMachine1 @marchersimon
Add -qa
f3b85fb 
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@marchersimon marchersimon merged commit c4f7f5a into main Oct 4, 2021
@marchersimon marchersimon deleted the raw branch October 4, 2021 08:30
@vitorhcl vitorhcl mentioned this pull request Dec 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicokosi nicokosi nicokosi left review comments

@marchersimon marchersimon marchersimon approved these changes

@einverne einverne einverne approved these changes

@sbrl sbrl sbrl approved these changes

@pixelcmtd pixelcmtd pixelcmtd approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@CleanMachine1 @tldr-bot @pixelcmtd @navarroaxel @einverne @nicokosi @sbrl @marchersimon