-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fstab: add page #7883
fstab: add page #7883
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should add something that is not a command.
Although, one example cgroups comes to mind.
Thoughts ?
It's a good idea. Just instead of code samples any other one-liners will be placed such as configs. The problem arises when tl;dr page describes config that doesn't support joining several lines and mandates |
`echo '/swapfile none swap defaults 0 0' | tee --append /etc/fstab` |
ill fix the errors soon, i need to study as of right now, thanks everyone for the help so far :) |
fixed errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hopefully fixed the errors mentioned above. if there are still problems please let me know
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
hi, recently ive had some stress with school but i did not forget this pr. thanks for checking in, i'll resolve errors soon |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix syntax errors. 😄
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove examples from description: they make it too long.
Errors are fixed because no author response is obtain for a long time. |
I'm really not sure if we should accept this page. We had this situation a few times in the past and always decided that it should be addad to another project like I know it's often frustrating to have to reject seemingly good ideas, but we just don't have the capabilities to maintain all this. When we accept non-command pages, there would have to be a whole new style guide, probably new syntax, new rules, etc. (Also, |
ill be honest, i kinda forgot about this contribution. originally though, i thought of tldr being an 'ez help' kinda program which the name suggests. im not sure if youd have to make a whole new stylesheet guide for 'non command pages' cuz i think no matter what man page, it can be shortened for this project the decision is up to you after all tho since i didnt really do much except the initial commit |
Thanks for understanding. You could try contributing your page to cheat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not sure if we should accept this page. We had this situation a few times in the past and always decided that it should be addad to another project like
cheat.sh
instead.
I think we can accept 1 o 2 examples like the following:
echo '/swapfile none swap defaults 0 0' | tee --append /etc/fstab
but not an explanation about the structure of this file.
@navarroaxel but we can't just throw in |
@marchersimon well, in the example description we can explain some params. Anyway this isn't a command, and |
Sorry, tldr-pages only documents commands, so we can't accept this page. However, there are a number of sister projects like the aforementioned |
common/
,linux/
, etc.)Version of the command being documented (if known):
This is my first time making a pull request and I don't quite know how it works. Please tell me if I did anything wrong.