Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newcommand should fail if already defined #36

Closed
tlienart opened this issue Jun 26, 2018 · 1 comment
Closed

newcommand should fail if already defined #36

tlienart opened this issue Jun 26, 2018 · 1 comment
Labels
parser

Comments

@tlienart
Copy link
Owner

we look for the first definition so if there's two it will ignore the second one. it'd be better to just fail when newcommands are found.
@tlienart
Copy link
Owner Author

this is still the case. Two ways forward:

  1. Look for the last definition that matches the name and take that one
  2. Bug when defining a command that already has a definition.

2 is more "idiomatic" latex but 1 is potentially more flexible for people who want to redefine stuff more. (thereby also avoiding the need for a \renewcommand or something).

tlienart added a commit that referenced this issue Nov 6, 2018
@tlienart
closes #36 with renewing of newcommand
87aad2f
@tlienart tlienart closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tlienart