Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding: avoid asking for email address before waitlisting user #3882

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jamesacklin
Copy link
Member

@jamesacklin jamesacklin commented Sep 3, 2024

Bifurcates the first stage of the signup flow based on hosting availability. Fixes TLON-2656

We're coming from this world:

Enter email address -> Check inventory -> (N) Join waitlist
                                       -> (Y) Enter password

...which seems like a bait-and-switch for their email address.

Instead:

Check inventory -> (N) Join waitlist -> Enter email
                -> (Y) Enter email   -> Enter password

Here are some videos of the change in action.

No inventory (waitlist):

Screen.Recording.2024-09-03.at.6.11.07.PM.mov

Normal signup:

Screen.Recording.2024-09-03.at.6.16.28.PM.mov

@jamesacklin
Copy link
Member Author

Adding @e-shee for copy review. :)

@e-shee
Copy link

e-shee commented Sep 3, 2024

LGTM

Copy link

linear bot commented Sep 3, 2024

Copy link
Contributor

@dnbrwstr dnbrwstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, code lgtm.

@jamesacklin jamesacklin merged commit bdd6fb9 into develop Sep 4, 2024
1 check passed
@jamesacklin jamesacklin deleted the ja/inventory-check branch September 4, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants