fix: literal type to match only when value types equal

tlux · Mar 25, 2024 · 05f44a7 · 05f44a7
1 parent ff0be8c
commit 05f44a7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/vx/literal.ex b/lib/vx/literal.ex
@@ -36,12 +36,10 @@ defmodule Vx.Literal do
   end
 
   defimpl Vx.Validatable do
-    def validate(%{value: value}, actual_value) do
-      if value == actual_value do
-        :ok
-      else
-        {:error, "must be #{Kernel.inspect(value)}"}
-      end
+    def validate(%{value: value}, value), do: :ok
+
+    def validate(%{value: value}, _value) do
+      {:error, "must be #{Kernel.inspect(value)}"}
     end
   end
 

diff --git a/test/vx/literal_test.exs b/test/vx/literal_test.exs
@@ -15,6 +15,8 @@ defmodule Vx.LiteralTest do
         assert {:error, error} = Vx.validate(Vx.Literal.t(value), "bar")
         assert Exception.message(error) == "must be #{inspect(value)}"
       end)
+
+      assert {:error, _} = Vx.validate(Vx.Literal.t(123.0), 123)
     end
   end
 end