-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not so small-ish fixes #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhejazi
reviewed
Mar 27, 2021
nhejazi
reviewed
Mar 28, 2021
@nhejazi, we fixed this up this morning. Should be good to go, pending a look from you. Thanks for your help with it! |
Great, I just added some more documentation/style edits. Assuming my most recent commits don't fail the CI build checks, then this LGTM for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small-ish fixes throughout:
lambda.min.ratio
to 1e-4 (The previous default overpenalized)fit_hal
#80cpp
files that contained documentation but no actual code at allRcpp
documentation to suppressRoxygen
errors (NOTE: the line before// [[Rcpp::export]]
cannot be a comment (i.e.,//
), but must be validRcpp
-Roxygen
(e.g.,//'
)Rcpp
functions, eliminatingget_pnz
andget_xscale
, which were exact copies ofcalc_pnz
andcalc_xscale