Make the move to omigrate.0.3.0 from 0.1.0 easier
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmattio
approved these changes
Oct 26, 2022
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 26, 2022
CHANGES: - Support driver listing (tmattio/omigrate#8, @maiste) - Simplify migration to version 0.3 (tmattio/omigrate#10, @maiste)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the #9 discussion, it appears that the behaviour is different between the two versions as one stacks the version, whereas the other truncates the table (
0.3.0). Asomigrate.0.3.0tries to fetch one result, it can get a random line from the old schema (with multiple entries). To avoid we need to get the last version in the database. This is the best we can do to simplify this transition.The idea is to keep the old version schema until a new migration is created and truncate the table. However, it won't affect the operation if no new migration is applied.
Note that it still requires an action from the user to add the
dirtycolumn with the following SQL command:We need to release this ASAP so people can make the transition quickly 👍
Fixes #9