Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResourceWarning: unclosed file in setup.py #1

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix ResourceWarning: unclosed file in setup.py #1

merged 1 commit into from
Jan 7, 2019

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jan 7, 2019

Signed-off-by: Mickaël Schoentgen contact@tiger-222.fr

@BoboTiG
Fix ResourceWarning: unclosed file in setup.py
c50ce7c 
Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
tmbo
tmbo approved these changes Jan 7, 2019
View reviewed changes
Copy link
Owner

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, thanks for the fix 👍

@tmbo tmbo merged commit 0106ecc into tmbo:master Jan 7, 2019
@BoboTiG BoboTiG deleted the fix-resource-leaks branch January 7, 2019 15:51
@mart1n mart1n mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoboTiG @tmbo