Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentloaders: add AssemblyAI document loader #668

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

marcusolsson
Copy link
Contributor

This PR adds the AssemblyAI document loader from LangChain and LangChain JS.

Unfortunately, due to the number of supported formats (in formatTranscript()), I had to increase the cyclop max complexity from 10 to 12. I first tried to break up the switch case, but then the exhaustive check failed.

I could also split the loader into a loader for each format. Let me know if you'd prefer it that way.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@marcusolsson
Copy link
Contributor Author

marcusolsson commented Mar 13, 2024

FWIW I don't think the GitHub workflow use the .golangci-lint.yaml configuration. When I run golangci-lint run -c .golangci.yaml locally, I'm getting ~13 linter errors across the codebase.

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, can you attach comments on all new exported symbols?

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not huge on bumping the max limit here but it seems ok, I filed #678 to address dev/CI linting config.

@marcusolsson
Copy link
Contributor Author

Thanks! 🙏 Is there anything else you'd like me to do before this can be merged?

@tmc
Copy link
Owner

tmc commented Mar 18, 2024

Nope, going to merge!

@tmc tmc merged commit 0218733 into tmc:main Mar 18, 2024
3 checks passed
@marcusolsson marcusolsson deleted the documentloaders/assemblyai branch March 19, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants