-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentloaders: add AssemblyAI document loader #668
Conversation
d0de438
to
c755672
Compare
FWIW I don't think the GitHub workflow use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, can you attach comments on all new exported symbols?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not huge on bumping the max limit here but it seems ok, I filed #678 to address dev/CI linting config.
Thanks! 🙏 Is there anything else you'd like me to do before this can be merged? |
Nope, going to merge! |
This PR adds the AssemblyAI document loader from LangChain and LangChain JS.
Unfortunately, due to the number of supported formats (in
formatTranscript()
), I had to increase thecyclop
max complexity from 10 to 12. I first tried to break up the switch case, but then theexhaustive
check failed.I could also split the loader into a loader for each format. Let me know if you'd prefer it that way.
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.