Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change time-to-next to a proper data attribute #39

Merged
merged 1 commit into from
May 17, 2014
Merged

Change time-to-next to a proper data attribute #39

merged 1 commit into from
May 17, 2014

Conversation

commadelimited
Copy link
Contributor

Change over the time-to-next attribute to be a proper data attribute. Addresses #35.

@tmcw
Copy link
Owner

tmcw commented May 17, 2014

Ooh, didn't know that data attributes get auto-camelcased, neat!

tmcw added a commit that referenced this pull request May 17, 2014
Change time-to-next to a proper data attribute
@tmcw tmcw merged commit 50406a2 into tmcw:gh-pages May 17, 2014
@bcomnes
Copy link
Contributor

bcomnes commented May 21, 2015

Do data attributes really get camel cased? As far as I can tell thats an error since it only works when I change it to data-time-to-next in the getAttribute. I can send a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants