Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Private Fields as _camelCase #171

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Generate Private Fields as _camelCase #171

merged 1 commit into from
Nov 7, 2022

Conversation

DamianSuess
Copy link
Contributor

The generator outputs private fields as _camelCase rather than _PascaCase

As per inquiry, #170

@DamianSuess DamianSuess changed the title Generate Fields as _camelCase Generate Private Fields as _camelCase Jul 23, 2022
@tmds tmds merged commit 9f126c1 into tmds:main Nov 7, 2022
@tmds
Copy link
Owner

tmds commented Nov 7, 2022

Thanks!

@tmds tmds mentioned this pull request Nov 7, 2022
Closed
@DamianSuess DamianSuess deleted the feature/GenerateCamelCaseFields branch November 8, 2022 22:59
@DamianSuess
Copy link
Contributor Author

Thank you @tmds

@tmds tmds mentioned this pull request Mar 29, 2023
Closed
@tmds tmds mentioned this pull request Apr 22, 2023
Closed
tmds added a commit that referenced this pull request Apr 22, 2023
@tmds
Revert "Generator outputs private fields as _camelCase rather than …
3db870c 
…`_PascalCase` (#171)"

The MessageReader and MessageWriter expect the casing to match
the item keys in the dictionary.
tmds added a commit that referenced this pull request Apr 22, 2023
@tmds
Revert "Generator outputs private fields as _camelCase rather than …
74848ba 
…`_PascalCase` (#171)" (#204)

The MessageReader and MessageWriter expect the casing to match
the item keys in the dictionary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamianSuess @tmds