wip #9
wip #9
Conversation
Many of the API calls and web hooks return string keys, and it’s not always trivial to pass through atomization of keys as an option to Jason or another library. As a result, practicing a little empathy here in the struct.
Pipedrive webhook POST requests to the plug. It will process known events (currently only the updated.deal event type, but more to come), And publish events via Registry.LineDriveEvents. See LineDrive.Incoming.Handler for more information.
…tead of compile time
add typed struct library to reduce typing boiler plate
only enforce status and type on activity
add handling of find user endpoint
handle base url not having protocol
add support for creating a new person
add owner id field to person struct
add organization name to search person results
pipedrive_oauth.livemd
Outdated
| @@ -0,0 +1,98 @@ | |||
| # Pipedrive OAuth | |||
There was a problem hiding this comment.
Did you mean to commit this with all the ids and keys and stuff? I would have expected this to use livebook secrets and System.get_env("LB_PIPEDRIVE_CLIENT_ID"), for example, if the lived is useful to help people know how to use it
There was a problem hiding this comment.
whoops. i did not mean to commit this.
There was a problem hiding this comment.
whoops. i did not mean to alter the entire git history.
| @@ -34,6 +34,25 @@ defmodule LineDrive do | |||
| Tesla.client(middleware) | |||
| end | |||
|
|
|||
| def build_client(refresh_token, client_id, client_secret, base_url) do | |||
There was a problem hiding this comment.
Should the other function that uses an api key be updated to the same name or stay separate?
There was a problem hiding this comment.
I'm open to other ways of doing it, but it feels like a sufficiently different thing. client only ever returns a client struct, where build_client is doing more stuff that can fail, and returns a tuple.
|
add oauth client |
No description provided.