Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for IoC/DI and mocking #146

Closed
tmenier opened this issue Nov 20, 2016 · 1 comment
Closed

Better support for IoC/DI and mocking #146

tmenier opened this issue Nov 20, 2016 · 1 comment
Labels
enhancement
Milestone
Flurl.Http 1.1

Comments

@tmenier
Copy link
Owner

tmenier commented Nov 20, 2016

Add a FlurlClient constructor that a FlurlHttpSettings object, making it more friendly to use with IoC containers/constructor injection. Also add a IFlurlClient interface, which will also make FlurlClient easier to mock with tests.
@tmenier tmenier added this to the Flurl.Http 1.1 milestone Nov 20, 2016
tmenier added a commit that referenced this issue Nov 20, 2016
@tmenier
#146 FlurlClient now has a constructor that takes a FlurlHttpSettings…
f0cfb70 
… object. Also one that takes a Action<FlurlHttpSettings> for if you just want to change one or a few default settings.
@tmenier tmenier mentioned this issue Nov 20, 2016
Closed
tmenier added a commit that referenced this issue Nov 21, 2016
@tmenier
#146 extracted IFlurlClient interface
adae57d
@kroniak
Copy link
Collaborator

kroniak commented Nov 21, 2016

@tmenier Great job! I am testing!

@tmenier tmenier closed this as completed Nov 29, 2016
@tmenier tmenier removed the ready label Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Flurl.Http 1.1
Development

No branches or pull requests
2 participants
@tmenier @kroniak