Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle items under the player on level arrival and generally #661

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

zenzombie
Copy link
Collaborator

Fixes #214

The only breaking change is the removal of HAS_ITEM in the player placement logic of startLevel in RogueMain. The other changes passed regression testing against the release branch.

@tmewett
Copy link
Owner

tmewett commented Mar 4, 2024

Can you describe the changes? Looks like there are some appearance changes

@zenzombie
Copy link
Collaborator Author

Yes there are appearance changes. Below is from the changes file.

I'll try to post some screenshots and I'll fix the conflicts.

  • Fixed a bug where arriving on a level with items "obstructing" the stairs would cause the player to be moved to a non-item location without using a turn.
  • When the player arrives on a level and occupies a location with an item, a message is now displayed in the message pane.
  • If the player occupies a location with an item, the item is now shown in the sidebar. Additionally, the item is included in the description when inspecting the player's location.
  • When inspecting a location, item descriptions now include details if space permits.

@zenzombie
Copy link
Collaborator Author

Player is standing on a sword (OLD)
image

Player is standing on a sword (NEW)
image

Player arrives on a level with food at the stairs (OLD)
image

Player arrives on a level with food at the stairs (NEW)
image

@tmewett
Copy link
Owner

tmewett commented Mar 5, 2024

Ah sorry, I think I misread some code - and I missed the change file! Thanks for the extra details, LGTM

@tmewett tmewett merged commit cd04993 into tmewett:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If you place alot of items in front of stairs and your inventory is full you "jump" over all of them.
2 participants