Improve and refactor auto-targeting when throwing something or using a staff or wand #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I guess the concern about being super-specific about targeting rules is that players might not know the rules and they'll see the target cycling as inconsistent/broken. Thanks for the thorough accounting of changes! LGTM, just needs conflicts fixing |
zenzombie
force-pushed
the
auto-targeting-refactor
branch
from
dddef42
to
c0611c6
Compare
|
Ok conflicts resolved. I think the specificity in targeting is helpful but if there are scenarios where it causes confusion we can make changes. Future changes to targeting rules should be much easier with everything centralized. |
zenzombie
added a commit
to zenzombie/BrogueCE
that referenced
this pull request
May 25, 2024
* Add functions and enum * Refactor targeting functions * Remove creatureIsTargetable * Add negationWillAffectMonster, fix rethrow, update autotarget logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #658
Fixes #420
Centralizes the player auto-targeting logic and makes many behavior modifications, as described in the changes file. I tried to implement improvements that I think make sense, but let me know if I should back out any of them.
These changes should have no effect on replays because I think only the final selected target is recorded, not the candidate targets and I don't think the method of target selection (auto vs. manual) is relevant.