-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display inventory when victory and add new screen to display achievements (no place when inventory shown). #74
Conversation
achievements (no place when inventory shown).
@@ -1233,7 +1245,17 @@ void victory(boolean superVictory) { | |||
sprintf(buf, "%li", totalValue); | |||
printString(buf, mapToWindowX(60), min(ROWS-1, i + 1), &lightBlue, &black, dbuf); | |||
|
|||
i += 4; | |||
funkyFade(dbuf, &white, 0, 120, COLS/2, ROWS/2, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly fond of this second funkyFade, I think it should just go to the next screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, without this funkyfade, I don't understand how to clear this dbuf correctly and write my text. I have some strange behaviour. With : clearDisplayBuffer and deletesMessages, my achievements list is not display. Maybe a function to force redraw ? But there is no call before in this function. A idea ?
Thanks for the PR, I've left some comments. In the future, could you use the same PR if you're still re-implementing the same feature? You can rebase and force-push etc. to overwrite the commits on a branch. I will close #73 for now. |
Yes sorry ! I'v searched on github how to do that. I note command for next time ! |
Clear screen before ask to save file record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally happy with this, thank you! I added some tweaks to a branch which I merged in 35af2d7, would you say this suitable?
Yes, nice ! |
Great, closing as merged. |
No description provided.