Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display inventory when victory and add new screen to display achievements (no place when inventory shown). #74

Closed
wants to merge 2 commits into from

Conversation

kz-dev
Copy link
Contributor

@kz-dev kz-dev commented Apr 5, 2020

No description provided.

achievements (no place when inventory shown).
src/brogue/RogueMain.c Outdated Show resolved Hide resolved
@@ -1233,7 +1245,17 @@ void victory(boolean superVictory) {
sprintf(buf, "%li", totalValue);
printString(buf, mapToWindowX(60), min(ROWS-1, i + 1), &lightBlue, &black, dbuf);

i += 4;
funkyFade(dbuf, &white, 0, 120, COLS/2, ROWS/2, true);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly fond of this second funkyFade, I think it should just go to the next screen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, without this funkyfade, I don't understand how to clear this dbuf correctly and write my text. I have some strange behaviour. With : clearDisplayBuffer and deletesMessages, my achievements list is not display. Maybe a function to force redraw ? But there is no call before in this function. A idea ?

src/brogue/RogueMain.c Outdated Show resolved Hide resolved
@tmewett
Copy link
Owner

tmewett commented Apr 5, 2020

Thanks for the PR, I've left some comments.

In the future, could you use the same PR if you're still re-implementing the same feature? You can rebase and force-push etc. to overwrite the commits on a branch. I will close #73 for now.

@kz-dev
Copy link
Contributor Author

kz-dev commented Apr 6, 2020

Thanks for the PR, I've left some comments.

In the future, could you use the same PR if you're still re-implementing the same feature? You can rebase and force-push etc. to overwrite the commits on a branch. I will close #73 for now.

Yes sorry ! I'v searched on github how to do that. I note command for next time !

@kz-dev kz-dev requested a review from tmewett April 9, 2020 08:26
tmewett added a commit that referenced this pull request Apr 11, 2020
Merges pull request #74.
Copy link
Owner

@tmewett tmewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy with this, thank you! I added some tweaks to a branch which I merged in 35af2d7, would you say this suitable?

@kz-dev
Copy link
Contributor Author

kz-dev commented Apr 13, 2020

Generally happy with this, thank you! I added some tweaks to a branch which I merged in 35af2d7, would you say this suitable?

Yes, nice !
Good idea for funkyfade.

@tmewett
Copy link
Owner

tmewett commented Apr 13, 2020

Great, closing as merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants