Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster file #77

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Faster file #77

merged 2 commits into from
Nov 4, 2023

Conversation

tmontaigu
Copy link
Owner

There is still some unwraps left in File::record function.

The choice is wether to change those unwraps and make File::record return a Option<Result<Record, Error>> but it makes
the caller do 2 unwraps (unless using while let Some)

or delay the seek / reading of data until either some FieldRef::write or read is called

@tmontaigu tmontaigu merged commit b016dca into master Nov 4, 2023
4 checks passed
@tmontaigu tmontaigu deleted the faster-file branch November 4, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant