Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery status changes causes incorrect window refresh #44

Closed
oblitum opened this issue Nov 22, 2016 · 8 comments
Closed

Battery status changes causes incorrect window refresh #44

oblitum opened this issue Nov 22, 2016 · 8 comments
Labels

Comments

@oblitum
Copy link

oblitum commented Nov 22, 2016

Hi, this is what started to happen on battery status change after some weeks ago. It made me stop using the plugin:

screenshot from 2016-11-22 12-25-23

When I press Enter after that kind of status change, I get:

screenshot from 2016-11-22 12-31-19

As can be seen, a caret is shown in the left-bottom corner, not the tmux bar, which got hidden bellow the window canvas.

~ ❯❯❯ tmux -V
tmux 2.3

~ ❯❯❯ xfce4-terminal --version
Copyright (c) 2003-2016
        The Xfce development team. All rights reserved.
@martinbeentjes
Copy link
Collaborator

martinbeentjes commented Nov 22, 2016

Do you use the most recent version of the plugin? What other plugins are you using? Is this issue possibly caused by some other plugin?

@oblitum
Copy link
Author

oblitum commented Nov 22, 2016

OK, just after reporting, it seems I have found the cause... it seems when the battery charging unicode character is 🔋 , which in my font is like the one in the screenshot, the issue happens. I'm wondering whether this happens because the character is tall.

If I replace the character with another normal one, the issue doesn't happen.

@martinbeentjes
Copy link
Collaborator

Hmm, interesting case. The icon is a two byte unicode character. Does your terminal support that correctly?

@oblitum
Copy link
Author

oblitum commented Nov 22, 2016

I think yes, I have no issue with unicode, and the other battery-full character, which is an unicode one too, doesn't provide the issue.

Answering previous questions, all plugins updates recently and I have bisect that the issue is with the tmux-battery.

@martinbeentjes
Copy link
Collaborator

Well, I know that in #31 we discovered that two byte unicode characters can have some buggy behavior all the way into libc. I am wondering if the height of an character (more the height of an icon in this case) is the cause of this issue.

So the character you are using, is causing the terminal (or tmux?) to do a carriage return randomly?

@oblitum
Copy link
Author

oblitum commented Nov 22, 2016

Yes. I'm sorry, I guess it's just an unicode issue now, I have done some more tests and it seems the behavior happens anytime an unicode character gets involved in any of the state changes. What I find strange though is that I've been using this plugin for quite a long time in the same xfce4 terminal emulator and it always worked fine, then one day after an update this stopped behaving well.

@oblitum
Copy link
Author

oblitum commented Nov 22, 2016

I think it's a duplicate of #31.

@oblitum oblitum closed this as completed Nov 22, 2016
@oblitum
Copy link
Author

oblitum commented Sep 9, 2017

I think this and #31 should be fixed by now at least on ArchLinux, glibc was just upgraded to 2.26, supporting Unicode 10: tmux/tmux#1057 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants