Include parallel-safe types from RcppParallel #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IANAL, but while this would be okay with me, I believe this would require sign-off from all authors on the RcppParallel repository. |
|
Here goes: @romainfrancois @gregvdb @jjallaire |
|
I don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love for RcppThread to have the parallel-safe wrappers that RcppParallel has. I prefer RcppThread because of the lack of need for TBB.
@kevinushey, is it OK with you to include this code in RcppThread even though it's MIT and RcppParallel is GPL?
If it is, I'll write some docs for RcppThread to mention the inclusion but I don't want to put too much work into this unless there's a green light from the people I'm taking the main code from.
Closes #73.