Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - issues #212

Merged
merged 57 commits into from
May 18, 2020
Merged

bugfix - issues #212

merged 57 commits into from
May 18, 2020

Conversation

timnicolas
Copy link
Owner

@timnicolas timnicolas commented May 14, 2020

close #110 Accurate classes diagram
close #211 Enemies cannot walk through dead enemies
close #213 Remove french in the code, for example Player::BonusActifs
close #217 add docs in all code
close #26 create documentation on github

c'etait long mais j'ai resolu les plus de 2500 lignes de warnings de doc... je mettrais a jour la doc github pages quand tout sera sur master

maintenant pour checker les warning de docs, il faut faire

make doc

pour mettre a jour la doc sur github pages (c'est bien de le faire de temps en temps sur master)

make ghpages

pour le moment le make doc est dans travis mais pas dans les pre-commit (pour eviter que ca prenne trop de temps de commit)

@timnicolas timnicolas added the bug Something isn't working label May 14, 2020
@timnicolas timnicolas added this to the Game rules milestone May 14, 2020
@timnicolas timnicolas self-assigned this May 14, 2020
@timnicolas timnicolas marked this pull request as draft May 14, 2020 08:58
@timnicolas timnicolas changed the title bugfix - isues bugfix - issues May 14, 2020
@timnicolas timnicolas marked this pull request as ready for review May 18, 2020 17:06
Copy link
Collaborator

@zer0nim zer0nim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice les comandes marchent bien, gg pour les commentaire ça a du te prendre beaucoup de temps 🤯

Copy link
Collaborator

@ebaudet ebaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel ! 👍

@timnicolas
Copy link
Owner Author

j'ai fix les conflicts, si ca compile, je merge

@timnicolas timnicolas merged commit 8a1cc61 into master May 18, 2020
@timnicolas timnicolas deleted the bugfix/multiples-issues branch May 18, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants