Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes to the contents of the articles #17

Merged
merged 5 commits into from
May 18, 2024

Conversation

src4026
Copy link
Contributor

@src4026 src4026 commented Apr 29, 2024

Hi👋 Highly insightful website on guides to digital safety! A big thanks for the great work done on this website. While reading along, I noticed a couple of minor issues. Here's a PR with my proposed changes.

Changes

  1. "attack vetor" -> "attack vector"
  2. "...cars Pearson..." -> "...cars. Pearson"
  3. Added closing **s where they were missing in metadata.mdx & backups.mdx .

@src4026 src4026 marked this pull request as draft May 2, 2024 18:41
@src4026
Copy link
Contributor Author

src4026 commented May 2, 2024

Converted to draft because I noticed a potential typo in another page. I'll make the PR ready for review after I complete my reading of the entire website.

@tnonate
Copy link
Owner

tnonate commented May 7, 2024

Sorry it's taken me so long to reply to this. I appreciate you finding these errors! Definitely just let me know when you're ready and I'll review it.

@src4026
Copy link
Contributor Author

src4026 commented May 7, 2024

Sorry it's taken me so long to reply to this.

No worries!

Also, could you please have a look at my previous two commits and check whether they're what you intended. For some reason there were two asterisks that were escaped using \. I didn't realise that to bold-en in .mdx the same syntax as standard markdown is used.

@src4026
Copy link
Contributor Author

src4026 commented May 7, 2024

The same case for a0a0648

@src4026 src4026 marked this pull request as ready for review May 7, 2024 14:04
@src4026
Copy link
Contributor Author

src4026 commented May 7, 2024

Alright, the PR is ready for review. I haven't completed reading the entire website yet due to limitations I face currently, so this is all I have for now.

@src4026 src4026 changed the title Fix typo and missing punctuation Miscellaneous fixes to the contents of the articles May 7, 2024
@tnonate
Copy link
Owner

tnonate commented May 18, 2024

I suck at using GitHub correctly. They all look right except for the Cryptomator one, that whole sentence should be bold and not just the one. I'll fix it after merging.

@tnonate tnonate merged commit ba446e1 into tnonate:main May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants